rust-csv

Summary v1.4.0 can panic in debug builds due to unchecked addition in the call path: If and , this overflows and panics. Why this is report-worthy This panic is reachable from public APIs (, , , ). The function docs do not mention this panic condition. The operation currently uses unchecked instead of /error return. Public API reproducer Call chain 1. Reader::from_reader(...) 2. Reader::seek_raw(..., pos_with_byte_u64_max) 3. Reader::read_byte_record(...) 4. Internal read_byte_record_impl(...) 5. set_byte(byte + nin as u64) at src/reader.rs:1649 panics when nin > 0 Actual behavior Panic on integer overflow (debug builds). Expected behavior Either: + avoid panic via checked arithmetic and return an error, or + explicitly document panic preconditions in API docs. Suggested fix At src/reader.rs:1649, replace unchecked addition with checked handling, e.g.: + byte.checked_add(nin as u64) and map overflow to Error, + or saturating behavior if that matches crate semantics. Version + crate: csv + version: 1.4.0

When writing an empty field with , the writer still produced instead of leaving it bare. The and methods in unconditionally wrote a pair of quote characters for empty fields without checking the configured quoting style. Added a guard so the empty-field quoting is skipped when the style is , and derived on to enable the comparison. Regression tests added in both and . Fixes #276.

The docs for say: This _never_ writes quotes, even if it would produce invalid CSV data. Based on that, I would expect the following program to output a line with followed by an empty line, followed by a line with : Expected output: But actual output is: Is there a way to prevent the writer from generating quotes? I am using csv 1.1.6.