factory

Fixes https://github.com/addyosmani/factory/issues/5 crashed with on macOS's bash 3.2 when no was given, because bash before 4.4 treats an empty array as unbound under . Expand with so the empty case falls through to the default test-path patterns. Add a case to that runs the proof without . It fails on bash 3.2 before the fix and passes after.

crashes on macOS's default bash (3.2) when called without , so it never reaches the default test-path detection. Under , bash 3.2 treats on an empty array as unbound. Bash 4.4+ does not, which is why it passes on Linux CI. always passes , so the default path is not covered. Expected: using the built-in test-path patterns.

Fixes the twelve findings in #3. All of them reproduced; the notes below are only for the places where the fix needed a decision, or where a boundary moved. Closes #3 Changed safety boundaries Negative-test proof got stricter, and slower to satisfy. used to accept any non-zero exit from the reverted run. Reverting deletes new implementation files, so a test that only imports the new module fails to load whether or not it asserts anything — an assertion-free test was certified as proving the fix. It now classifies the failure and reports only when the test actually ran and failed. The cost is real and worth agreeing to before merging: for a new module, the information isn't there. An import error and an assertion failure are the same observation from outside. That shape now reports , the verifier records , and the PR lands at with a human read. Bug fixes to existing code still get a genuine proof. A test command that fails silently is also , which is a deliberate nudge toward real runners over shell predicates. section 8 documents this. Every factory PR is now explicitly a draft. and the implement skill disagreed about what a non-draft factory PR meant. README, ADVICE.md, and the charter already say every run ends at a draft, so that's the reading I kept; the four conditions that used to gate draftness now set instead. If conditional drafts were the intent, this is the commit to reverse. sweeps at the end. A required gate the DETECT block never reached emitted neither nor and left the verdict GREEN. and on a Python repo both hit it, and both are configs 's own comments invite. Anyone who has already tuned may find a gate they thought was green is actually MISCONFIGURED — which is the point. The push guard matches refspec destinations. and both got through before. is now protected too; the path check looks for a write verb or a redirect target rather than any command that mentions a protected path, so still runs. Not fully fixed Back-pressure is read at run start and the counted label is applied at run end. The count now includes , which closes the window two overlapping runs used to slip through, but it isn't compare-and-swap. Claims have one in the remote ref; back-pressure doesn't, and I didn't invent one. Verification passes. New coverage, each written against the failing behavior first: — a required gate the stack never reaches must be MISCONFIGURED, and the stock config must still reach GREEN — load failure and unclassified failure both report ; the classifier is pinned to sample output from pytest, jest, vitest, go and cargo; co-located files stay out of the revert; the default path runs under bash 3.2 — every spelling of a push at a protected branch blocks, while claiming and releasing a claim branch still works — a repo where skipped must not report healthy