Last 12 weeks ยท 0 commits
2 of 6 standards met
[I originally noticed this issue with both react-hn and preact-hn. Since I understand that the preact version is based on the react version, I posted this issue at https://github.com/insin/react-hn/issues/94 first (9 days ago now). But I have seen no response there. I thought it might therefore be useful to also post it here. Maybe it can be fixed for the preact version even if it remains in the react one.] On my macOS machine, in Safari or Google Chrome, preact-hn very quickly shows the full front page of Hacker News, with all its items, but then it shows blinking dots, and then shows the items again. I assume the quick display is because of SSR. But why can't those items stay on the screen until everything is loaded? It looks terrible and slow the way it works now, but could appear very snappy if the SSR-rendered page just seemed to stay on the screen.
Preact is 3KB in size and preact-compat is a little over 3KB in gzipped size. IIRC React is over 40KB gzipped. Here are the break-downs of our dependencies both before and after conversion. React: !screen shot 2016-10-16 at 12 16 19 pm Preact: !screen shot 2016-10-16 at 12 15 00 pm Looking at the gzipped savings we're saving a little over 36KB. I wonder if there are any other savings to be had here.
#1 _But there are some other bugs?_ Warning: Failed form propType: You provided a prop to a form field without an handler. This will render a read-only field. If the field should be mutable use . Otherwise, set either or . Check the render method of . Warning: Failed form propType: You provided a prop to a form field without an handler. This will render a read-only field. If the field should be mutable use . Otherwise, set either or . Check the render method of .
Repository: addyosmani/preact-hn. Description: ๐ Preact Hacker News Stars: 120, Forks: 13. Primary language: JavaScript. Languages: JavaScript (88%), CSS (6.4%), HTML (5.7%). Homepage: https://preact-hn.appspot.com Open PRs: 1, open issues: 3. Last activity: 9y ago. Community health: 42%. Top contributors: addyosmani.