Last 12 weeks ยท 0 commits
5 of 6 standards met
Please be aware that vibe-coding contributions are ๐ซ STRICTLY PROHIBITED. We are humans behind these open source projects, trying hard to maintain good quality and a healthy community. Not only do vibe-coding contributions pollute the code, but they also drain A LOT of unnecessary energy and time from maintainers and toxify the community and collaboration. All vibe-coded, AI-generated PRs will be rejected and closed without further notice. In severe cases, your account might be banned organization-wide and reported to GitHub. PLEASE SHOW SOME RESPECT and do not do so. Before submitting the PR, please make sure you do the following: Read the Contributing Guide. Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate. Provide a description in this PR that addresses what the PR is solving and WHY**, or reference the issue that it solves (e.g. ). Ideally, include relevant tests that fail without this PR but pass with it. [x] <- Keep this line and put an between the brackts. Description In Iconify JSON, besides the field there is also an field, which the extension does not yet support โ for example, .
closes #104 closes #79 Implements the ability to fetch custom icon collections specified via HTTP/HTTPS URLs in the setting. Key changes: Modified in to differentiate between local file paths and remote URLs. Introduced a new utility in using to retrieve and parse JSON from URLs. Integrated this utility into to load collections from remote sources. Local file paths continue to be handled by and watched by . Remote URLs are fetched on configuration load/change. I'm awaiting your feedback on further testing. Description Linked Issues Additional context Testing with this html: !image Also fixed the debug command: see https://github.com/antfu/starter-vscode/pull/16
Repository: antfu/vscode-iconify. Description: ๐ Iconify IntelliSense for VS Code Stars: 569, Forks: 45. Primary language: TypeScript. Languages: TypeScript (97.7%), HTML (2%), JavaScript (0.4%). License: MIT. Homepage: https://marketplace.visualstudio.com/items?itemName=antfu.iconify Topics: iconify, iconsets, vscode, vscode-extension. Latest release: v1.0.0 (4mo ago). Open PRs: 2, open issues: 16. Last activity: 4mo ago. Community health: 85%. Top contributors: antfu, aki77, Legend-Master, heydong1, RebeccaStevens, jinghaihan, Sight-wcg, 9romise, tjx666, chenli1989 and others.
TypeScript
Describe the bug Activation error The extension is not working in Cursor. I noticed the icons were not visible (whereas the same config in VS Code works fine). Then I saw that running the commands result in an error (). And then I discovered in 's log that the extension is not activated: I wonder why, though. At first I thought that it was because the extension is being packed with , but I guess it's not a good lead, since most extensions depend on (i.e, https://github.com/slidevjs/slidev/blob/main/packages/vscode does the same and it is activated correctly). as external Then, comparing both extensions, I saw that both declare as external dependency. So, this might not be an issue either. Previous versions I could verify that the activation issue is present in versions , but not in . For some reason, I cannot test the versions in between (were they not published?). Cursor limitation Anyway, if this is just a limitation of Curor' plugin API, I understand. In that case, there's not much we can do. Edit**: I found that Prettier v12 had a similar issue, and it was because Cursor does not fully support ESM (wow): https://github.com/prettier/prettier-vscode/issues/3887 Reproduction Install the extension in VS Code on a project with icons and properly configured (it works), run the same project in Cursor (it does not work). Inspect the Extension Host output to see System Info Used Package Manager npm Validations [x] Follow our Code of Conduct [x] Read the Contributing Guide. [x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate. [x] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead. [x] The provided reproduction is a minimal reproducible of the bug. Contributions [ ] I am willing to submit a PR to fix this issue [ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Clear and concise description of the problem The extension is not updated on the open-vsx.org registry, the current extension version being Suggested solution Set up auto-publishing of the extension to the registry, as detailed in this guide Alternative Manually update the extension, as detailed in this guide Additional context _No response_ Validations [x] Follow our Code of Conduct [x] Read the Contributing Guide. [x] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.