Last 12 weeks · 2 commits
3 of 6 standards met
In the function converts to to produce the URL to download binaryen. This is the correct behviour for mac, but on linux the correct architecture label for releases is just . https://github.com/denoland/wasmbuild/blob/816dc32252284c93b57e7b03cff7b61b43c74594/lib/wasmopt.ts#L124 The correct URL for linux aarch64 should be (assuming binaryen version_130): https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-aarch64-linux.tar.gz not https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-arm64-linux.tar.gz which is what is produced currently.
Running now gets a project all the way to a working state instead of leaving the _deno.json_ setup to the reader. On top of scaffolding the crate, the command now: 1. Adds a task to the _deno.json_ file—the same task the manual setup instructions describe (), creating the file when it doesn't exist and filling in only what's missing when it does. 2. Runs in the folder. The config file is edited with , so comments, key order, and existing formatting all survive—a _deno.jsonc_ file (or a _deno.json_ with comments, which Deno also accepts) gets filled in like any other config. A _deno.json_ takes precedence over a _deno.jsonc_ when both exist, matching Deno's own resolution, and an existing task is never overwritten. The README is restructured to lead with the scaffold command and keep the manual setup as the alternative.
Right now we just say it fails, but we don't show the output. We should show the stderr and output the stdout on failure. https://github.com/denoland/wasmbuild/blob/f89f6f3338bd74a52db7ac20596e6a79d5fb35e6/lib/manifest.ts#L56 This can be tested out by putting some invalid dependency in a Cargo.toml file (I think).
Repository: denoland/wasmbuild. Description: Build tool to use Rust code in Deno and the browser. Stars: 354, Forks: 26. Primary language: TypeScript. Languages: TypeScript (86.1%), JavaScript (8.8%), Rust (5.1%). License: MIT. Homepage: https://jsr.io/@deno/wasmbuild Latest release: 0.22.0 (1mo ago). Open PRs: 1, open issues: 3. Last activity: 4w ago. Community health: 50%. Top contributors: dsherret, littledivy, sigmaSd, iuioiua, cailloumajor, mmastrac, g-plane, seanaye, dependabot[bot], nissy-dev and others.