Last 12 weeks · 0 commits
3 of 6 standards met
In the function converts to to produce the URL to download binaryen. This is the correct behviour for mac, but on linux the correct architecture label for releases is just . https://github.com/denoland/wasmbuild/blob/816dc32252284c93b57e7b03cff7b61b43c74594/lib/wasmopt.ts#L124 The correct URL for linux aarch64 should be (assuming binaryen version_130): https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-aarch64-linux.tar.gz not https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-arm64-linux.tar.gz which is what is produced currently.
Right now we just say it fails, but we don't show the output. We should show the stderr and output the stdout on failure. https://github.com/denoland/wasmbuild/blob/f89f6f3338bd74a52db7ac20596e6a79d5fb35e6/lib/manifest.ts#L56 This can be tested out by putting some invalid dependency in a Cargo.toml file (I think).
Repository: denoland/wasmbuild. Description: Build tool to use Rust code in Deno and the browser. Stars: 352, Forks: 26. Primary language: TypeScript. Languages: TypeScript (93.9%), Rust (5.2%), JavaScript (0.8%). License: MIT. Homepage: https://jsr.io/@deno/wasmbuild Latest release: 0.21.1 (3mo ago). Open PRs: 2, open issues: 3. Last activity: 3mo ago. Community health: 50%. Top contributors: dsherret, littledivy, sigmaSd, iuioiua, cailloumajor, mmastrac, g-plane, seanaye, dependabot[bot], nissy-dev and others.