Meta's BGP (Border Gateway Protocol) routing daemon for large-scale data center networks, built as part of the FBOSS forwarding stack.
by facebookC++
Last 12 weeks · 338 commits
3 of 6 standards met
Summary: X-link: https://github.com/facebook/fboss/pull/1403 The BGP OSS GitHub Actions build runs getdeps directly on a bare runner (unlike the on-diff/FBOSS builds, which run inside the CentOS Stream 9 container). getdeps fails while resolving the dependency: KeyError: 'project gcc12 has no fetcher configuration or system packages matching {distro=ubuntu, distro_vers=24.04, ...}' The manifest only declares CentOS Stream 9 RPMs (), with no ubuntu mapping and no fetcher, so getdeps cannot satisfy it on ubuntu. Both and depend on , so this blocks the whole BGP getdeps build. Add a mapping for ubuntu 24.04 (, , both available in noble's universe repo). This is purely additive — the CentOS path is unchanged — and fixes gcc12 resolution for every ubuntu getdeps consumer. Differential Revision: D111946117
What Fix a wrong FSDB path removal in . (NeighborWatcher.cpp:535) subscribes to via . But (NeighborWatcher.cpp:599) removed instead — a copy-paste from (NeighborWatcher.cpp:104), which is correct only for the config watcher. Why With enabled, calls on every daemon shutdown. The reachability watcher owns its own (NeighborWatcher.h:223/286), so the removal targeted the wrong path on the wrong manager: The subscription was never removed and leaked until process exit. A removal for , which this manager never subscribed to, was issued pointlessly. Test plan No behavioral change to the reachability logic itself; only the path removed on shutdown is corrected to match the path subscribed in . The existing suite (e.g. ) exercises the full run/stop lifecycle and continues to pass. The subscription-removal itself is only observable against a live FSDB server, so it is covered by the corrected path matching the used by the tests and the serializer.
Repository: facebook/BGP. Description: Meta's BGP (Border Gateway Protocol) routing daemon for large-scale data center networks, built as part of the FBOSS forwarding stack. Stars: 14, Forks: 5. Primary language: C++. Languages: C++ (93.9%), Python (3.7%), Thrift (1.4%), CMake (1%), C (0%). License: Apache-2.0. Open PRs: 1, open issues: 0. Last activity: 3h ago. Community health: 62%. Top contributors: induvsuresh, jaiharil, facebook-github-bot, srikrishnagopu, r-barnes, quark-zju, elangovan911-meta, giorgidze, muirdm, simuthus-fb and others.