Commit activity
Last 12 weeks ยท 1 commit
Community health
5 of 6 standards met
87
โREADMEโLicenseโContributingโCode of ConductโIssue TemplateโPR Template
Recent PRs & issues
Active ยท Last activity 1mo ago
See all on GitHub โThanks for proposing a pull request! To help us review the request, please complete the following: [x] sign contributor license agreement [x] I've ensured that all existing tests pass and added tests (when/where necessary) [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary) [x] I've added the proper label to this pull request (e.g. for bug fixes) Pull Request Details Describe what you accomplished in this pull request (for example, what happens before the change, and after the change) Test Plan Test Plan: Add your test plan here
Recent fixes
Hello Facebook! I'm trying this PR again, which got closed as stale by your bot previously. @rageandqq any chance you can take a look? โ sign contributor license agreement โ I've ensured that all existing tests pass and added tests (when/where necessary) โ I've updated the documentation (when/where necessary) and Changelog (when/where necessary) ๐ซ I've added the proper label to this pull request (e.g. for bug fixes) (I don't seem to have permission to do this) Pull Request Details We have an issue with high ANR rates on our Unity app, and the stack trace points to these two long standing open issues with this SDK: com.android.installreferrer is called in the main thread which leads to ANR #1039 InstallReferrerUtil.kt com.facebook.internal.InstallReferrerUtil$tryConnectReferrerInfo #672 I am not a Kotlin expert, but it seemed like this was a simple change to bring the call to over to a different thread. [!WARNING] This change assumes it is okay to make the callback from a different thread than . In my brief check of the codebase, this looked okay, but if necessary we may want to bring the callback back to the main thread. While doing this, I noticed that the try/catch for cleaning up the wouldn't work if an exception was thrown from , so I moved that cleanup to a finally block instead. Test Plan I have run the test app, but cannot test this code quite yet in my own app, as I haven't explored how to bring this over to Unity. I was hoping by starting here with this repository so I could get feedback before trying to get this brought in to the Unity package as well. If there is something I can do to help test this, please let me know! My goal here is to get the ball rolling with this conversation so that we can address the high ANR rates caused by this SDK.
Structured data for AI agents
Repository: facebook/facebook-android-sdk. Description: Used to integrate Android apps with Facebook Platform. Stars: 6467, Forks: 3695. Primary language: Kotlin. Languages: Kotlin (93.5%), Java (6.3%), Shell (0.2%), AIDL (0%). Homepage: https://developers.facebook.com/docs/android Latest release: sdk-version-18.0.3 (10mo ago). Open PRs: 1, open issues: 147. Last activity: 1mo ago. Community health: 87%. Top contributors: jingping2015, KylinChang, jawwad, maxalbrightmeta, mingflifb, swiese, dreamolight, mingcaozhang, kongxinzhu, laughingguitarist and others.