fb303 is a core set of thrift functions that provide a common mechanism for querying stats and other information from a service.
by facebookC++
Last 12 weeks · 131 commits
4 of 6 standards met
This diff aligns the OSS target naming with that in the internal BUCK build, enabling fb303 to build with PYTHON_EXTENSIONS enabled as well as clearing the way for other projects which depend on this one. Additionally, this change enables the "py3" thrift generator to run, which is required by other Meta OSS projects. Test: This change has been tested by running a full build of EdenFS in the sapling project, pinned to this revision. (There are other changes to folly, fbthrift, rust-common, as well as sapling necessary to get a green build, but this a step on that path.)
Summary Fixes facebook/fb303#7. The shared libraries built by the CMake build set but not , so and are produced with no SONAME. Without a SONAME, the runtime linker and packaging tooling cannot identify the libraries: / report the dependency as the raw file name rather than a stable SONAME. Distro packaging (Debian/RPM) that builds from the CMake install cannot emit a proper style dependency. Applications that or link by SONAME against an installed fb303 fail to resolve it after an upgrade. Changes Derive from the major component of in . Set alongside the existing on both and , so the SONAME (, ) stays stable across minor/patch releases. Verification The issue is reproducible from the current : with no in both and . The updated CMake configures cleanly with both on and off.
Summary: X-link: https://github.com/prestodb/presto/pull/27469 X-link: https://github.com/facebookincubator/velox/pull/16969 Folly/experimental is just shims to the real code, rewriting all these references. #force_dangling_check == NO RELEASE NOTE == Reviewed By: grumeta Differential Revision: D97588319
Repository: facebook/fb303. Description: fb303 is a core set of thrift functions that provide a common mechanism for querying stats and other information from a service. Stars: 96, Forks: 68. Primary language: C++. Languages: C++ (49.5%), Python (36.9%), CMake (9.8%), Starlark (1.8%), Rust (0.8%). License: Apache-2.0. Open PRs: 12, open issues: 6. Last activity: 7h ago. Community health: 75%. Top contributors: ahornby, chadaustin, r-barnes, yfeldblum, simpkins, wez, ckwalsh, zertosh, fanzeyi, lukaspiatkowski and others.