fbthrift

Class HeaderClientChannel has a method to set CloseCallback when connection closed, which requires a naked pointer. The callback will be called in asynchronously. By normal thought, in this case, for an asynchronous callback object, developer will new a callback object, then pass the naked pointer to then function, and hope class HeaderClientChannel take the ownership, and free the callback object if necessary. But I found in the HeaderClientChannel class, in the function void HeaderClientChannel::messageChannelEOF(), after called closeCallback_->channelClosed(), then, the class assigns nullptr to the pointer: closeCallback_ = nullptr; In this case, memory leaking is occurred. But I think in the asynchronous case, developer haven't the responsibility to holder a callback and free them. And no any note to say, need to delete this in the function channelClosed().

Tested in hsthrift as part of this PR: https://github.com/facebookincubator/hsthrift/pull/174

switches on , whose type is a class with an . Older Clang (e.g. Apple Clang 15 / Xcode 15) rejects the labels of such class-type switches with: Switch on (the public member) instead, so every switch operates on the plain enum. No behavioral change; case labels are unchanged. Builds unchanged on newer Clang/GCC and fixes older Clang.