Last 12 weeks · 151 commits
6 of 6 standards met
Description This PR fixes a crash that occurs when loading placeholder images with malformed or corrupted drawable resources. Problem The method in does not catch . When a placeholder drawable resource is malformed or corrupted, the exception propagates and crashes the app. Stack Trace from Issue #2830 Fix Added a try-catch block around to catch and return instead of crashing. Changes : Wrapped call in try-catch for Testing Verified the fix handles missing/corrupted drawable resources gracefully Returns instead of crashing when drawable cannot be loaded Fixes #2830
Description This PR fixes a crash that occurs when loading placeholder images with malformed or corrupted drawable resources. Problem The method in does not catch . When a placeholder drawable resource is malformed or corrupted, the exception propagates and crashes the app. Stack Trace from Issue #2830 Fix Added a try-catch block around to catch and return instead of crashing. Changes : Wrapped call in try-catch for Testing Verified the fix handles missing/corrupted drawable resources gracefully Returns instead of crashing when drawable cannot be loaded Fixes #2830
Motivation Fixes broken example of loading svg using fresco. Fixes https://github.com/facebook/fresco/issues/2820 Test Plan Vito's java implementation 1. Launch showcase project 2. Open svg screen using sidebar menu 3. Enable toggle "Svg support enable" 4. Press "kill now" in an appeared dialog 5. Open showcase application 6. Make sure fresco's svg logo is displayed Vito's kotlin implementation 1. Launch showcase project 2. Open settings screen using sidebar menu 3. Enable vito -> "Use kotlin implemention" setting 4. Open svg screen using sidebar menu 5. Enable toggle "Svg support enable" 6. Press "kill now" in an appeared dialog 7. Open showcase application 8. Make sure fresco's svg logo is displayed
Repository: facebook/fresco. Description: An Android library for managing images and the memory they use. Stars: 17156, Forks: 3740. Primary language: Kotlin. Languages: Kotlin (47.3%), Java (46.9%), C++ (4.9%), C (0.3%), Makefile (0.2%). License: MIT. Homepage: https://frescolib.org/ Latest release: v3.7.0 (2w ago). Open PRs: 15, open issues: 246. Last activity: 22h ago. Community health: 87%. Top contributors: oprisnik, defHLT, massimocarli, refinedata, tyronen, kirwan, steelrooter, Andy-Wu25, foghina, lukkm and others.