4 of 6 standards met
Summary: Increase max NC-SI response payload to 1480 in kernel for big response packets that are used in Broadcom OEM GetDebugData. Test plan: fby2 and fbgp2 image build (pass) Update and boot the image on YosemiteV2 and V2.5 (pass) BMC initializes NC-SI interface with NIC (pass) Use ncsi-util send various commands such as 0x18, 0x19 and 0x1a (pass) Use ncsi-util to perform PLDM firmware update (pass) Use ncsi-uitl Broadcom OEM GetDebugData command to retrieve core dump and crash dump from NIC (pass) root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d coredump -o /tmp/nic.core Debug data length: 14216032 Received: 14216032/14216032 (100%) GetDebugData completed root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d crashdump -o /tmp/nic.crash Debug data length: 47824 Received: 47824/47824 (100%) GetDebugData completed
Repository: facebook/openbmc-linux. Description: Linux kernel consumed by OpenBMC Stars: 43, Forks: 37. Primary language: C. Languages: C (98%), Assembly (1.2%), Makefile (0.2%), Shell (0.2%), Perl (0.1%). Open PRs: 1, open issues: 1. Last activity: 2w ago. Community health: 75%. Top contributors: tao-ren, wxiaohua1217, Jerry-wiwynn, RickyWu-wiwynn, williamspatrick, zhdaniel12, potinlai, RoyTsao1224, DeanKalla, Andy-wiwynn and others.
Last 12 weeks · 0 commits
Summary: The NC-SI Broadcom OEM AEN (type 0x80) has a variable payload length per spec. For example, Host Error AEN can have paylod of 18 bytes. The ncsi_aen_handlers[] however hardcoded the payload length to 12 byte. This had caused kernel to fail to verify Broadcom AEN type 0x80 and discarded them. This patch fixes this by passing the NC-SI payload length from the packet instead of the fixed length to ncsi_validate_aen_pkt(). This makes process_NCSI_AEN() in ncsid to be able to receive Broadcom AEN of type 0x80. Test plan: fby3 (pass) Send Broadcom AEN type 0x80 (HostError) from NIC to BMC and check the BCM Host Error log (pass). In /var/log/messages 2021 Feb 7 18:14:37 dhcp-10-123-28-110.dhcp.broadcom.net user.crit fby3-da3230fb20-dirty: ncsid: NIC Event: , BCM Host Error, HostId=0x4 DownCnt=0x0001 In log-util 0 all 2021-02-07 18:14:37 ncsid NIC Event: , BCM Host Error, HostId=0x4 DownCnt=0x0001