4 of 6 standards met
The changes fix two issues: inability to build the project on macOS via due to 1) incorrect folder name in dependencies, 2) absence of a Folly link in Fizz examples, 3) hard failure of with newer CMake versions due to policy version enforcement, wrong name (on a macOS at least) for the link that propagates to consumer projects. As a result, on macOS, the project itself can successfully build via , and can be successfully linked as a dependency. I did notice one of the previous commits that does the opposite to in CMakeLists.txt—so I'm being careful by switching the change only by .
Repository: facebook/proxygen. Description: A collection of C++ HTTP libraries including an easy to use HTTP server. Stars: 8333, Forks: 1527. Primary language: C++. Languages: C++ (90.8%), Python (5.2%), CMake (3.3%), Shell (0.4%), JavaScript (0.2%). Latest release: v2026.02.23.00 (5d ago). Open PRs: 16, open issues: 24. Last activity: 6h ago. Community health: 75%. Top contributors: afrind, lnicco, hanidamlaj, ahornby, wez, w-o-o, simpkins, yfeldblum, kvtsoy, chadaustin and others.
Last 12 weeks · 305 commits
The comments in indicate that will be invoked for all handlers and that will never be invoked prior to : These comments do not match the implementation. For example, when a request contains an header (where is anything other than ), will invoke and detach the handler without having invoked . There are a lot of conditions between creating a handler and the session invoking , and the set of conditions varies depending on the underlying session type, so it's not obvious whether there are other scenarios that also violate the contract. Is this a defect in the implementation or the comments?
Differential Revision: D93368374
Summary: glog 0.7+ requires GLOG_USE_GLOG_EXPORT to be defined before including its headers. In the granular CMake build, glog::glog is linked PRIVATE on the monolithic proxygen library, so its INTERFACE_COMPILE_DEFINITIONS don't propagate to the individual OBJECT libraries. This causes build failures on macOS where homebrew installs glog 0.7+. After find_package(Glog), read the compile definitions from glog::glog and apply them globally via add_compile_definitions so all proxygen targets get them. Differential Revision: D93369119