Last 12 weeks · 1719 commits
5 of 6 standards met
Part two addressing #4306 This should make it so we can get the Pyrefly binary from the environment (and do that by default), as well as update how the selections are made. Not sure if this is going to be a popular decision, but I made only used when set in the setting since that makes testing easier, but that behavior may differ from expectations.
by default, pyrefly uses the version bundled with vscode instead of the version installed in the current python environment. most of the time this is not what the user wants, and can lead to the IDE reporting different errors than the CLI, which can be very confusing to the user. the bigger problem though is that is not cross-platform, meaning i cannot commit this in my : most other extensions use an setting to workaround this problem: https://docs.astral.sh/ruff/editors/settings/#importstrategy https://docs.basedpyright.com/latest/benefits-over-pyright/pypi-package-vscode-pinning/#ability-to-pin-the-version-used-by-vscode https://github.com/microsoft/vscode-pylint#usage-and-features
Describe the Bug It seems like gets eagerly resolved to as if every argument was required. But I think we should only do that if it's un-solved by the end of the call. In this case, the args provided in the first call is valid when considering optional params. Sandbox Link https://pyrefly.org/sandbox/?project=N4IgZglgNgpgziAXKOBDAdgEwEYHsAeAdAA4CeS4ATrgLYAEALqcROgOZ0Q3G6UN0AqADroRmGGEbwGAbQEAVOABo68gLoAKMIjoBhVFCipssGXMVqV6lQNSU2cHQrgBKHcVRw4YiXQDGBlDYqH4A1hr4OqwMKqRR6PwAvHQAjG50Hl4iIgzSGgGGwWEqaXQAxHQwlNSUAPw5eQVBIaElJS7ldLihIEogZJQSUKSEDLRQFBUACqSDYMN0aFh4%2BP646JBsAK6UqAwQ64QiFQDKMDB0ABYMDMSOAPT3A0MjvGz3MOj3mLh%2BcPd%2BdabHZ7A5fOhgXh0VAAN1Q0GMsDWGwg212%2B3WXWIGPQcCO6DIDEu6wAtDCqnAwXRkkIQABmQgpABMtJEIAAvn0QvtyQAxaAwChLHAEEjkdlAA (Only applicable for extension issues) IDE Information _No response_
Repository: facebook/pyrefly. Description: A fast type checker and language server for Python Stars: 6904, Forks: 493. Primary language: Rust. Languages: Rust (81.2%), Python (13.2%), MDX (3.2%), TypeScript (2%), Shell (0.2%). License: MIT. Homepage: http://pyrefly.org/ Topics: code-quality, ide, language-server, language-server-protocol, lsp, python, rust, type-annotations, type-check, type-checker, type-hints, typecheck, typechecker, typechecking, types, typing, vscode-extension. Latest release: 1.2.0 (3w ago). Open PRs: 100, open issues: 563. Last activity: 22m ago. Community health: 87%. Top contributors: stroxler, rchen152, ndmitchell, yangdanny97, kinto0, migeed-z, grievejia, connernilsen, samwgoldman, dluo and others.