squangle

What now actually erases the operation from the wait list when it is found, matching its documented behavior ("Searches for an operation in the queue and removes it"). Previously it only returned whether the operation was present. Why Two call sites depend on the removal side effect: (SyncConnectionPool.cpp) — on sync-wait timeout the operation must be dequeued before runs. With the bug the timed-out operation stayed queued, and the branch that waits for another thread to fulfill the operation could effectively never trigger. (ConnectionPool.h) — the throttling callback dequeues an operation that has just been marked failed; its comment states no other thread could have dequeued it yet, which only makes sense if dequeue actually removes. Without the erase, done/timed-out operations remain in until or a subsequent discards them. In the meantime is inflated, feeding and potentially delaying new connections. Testing Change is self-contained in . Erase is safe: it runs while holding the pool-data lock (or on the single client thread for the sync pool), and the operation is already marked failed/done at both call sites, so no other path can hold a reference that requires it to stay queued. Minimal behavioral change; no new dependencies.

It would be useful for userland Hack code in Slack to determine whether a connection obtained via an HHVM async_mysql connection pool was recycled from the pool or freshly opened, to allow more granular instrumentation than what pool-level stats currently provide. See https://github.com/facebook/hhvm/issues/8013 for the full rationale. Add two new connection fields that expose this information. A followup diff will expose these to HHVM/Hack.

Squangle as included in HHVM OSS currently doesn't compile. Apply fixes as needed to make the OSS build functional again. Use a new SQUANGLE_OSS compile definition for OSS-specific code and to conditionally include Meta-internal headers. Introduce OSS-specific shims for OdsCounterHelper and checked_memcpy(), which are internal. Use fmt::underlying() to format enums that do not have a corresponding formatter to avoid errors on debug builds with newer fmtlib versions. Move Query constructors from the header to the implementation to avoid pointer arithmetic with an incomplete definition of QueryArgument when populating .