Software to manage a chef-zero instance and use it to test changes on production servers.
by facebookRuby
Last 12 weeks · 3 commits
4 of 6 standards met
Basically a re-do of #158. This got rolled back because @babar wrote 3 different PRs and one of them was bad. This one wasn't. Technically it wasn't good either, as it only did , not really , or . This re-do fixes this. Still the same features: Can parametrize the number of threads in the config, or on the command line, default to the number of cores Reports hosts depending whether they failed ssh or something else Doesn't have any extra dependency, as the thread pool is done in a very simple way Test Plan: Ran it on my machine. Tried and , both worked. Signed-off-by: Olivier Raginel
Repository: facebook/taste-tester. Description: Software to manage a chef-zero instance and use it to test changes on production servers. Stars: 147, Forks: 68. Primary language: Ruby. Languages: Ruby (93.6%), Shell (4.6%), PowerShell (1.8%). License: Apache-2.0. Open PRs: 1, open issues: 12. Last activity: 1w ago. Community health: 75%. Top contributors: jaymzh, odcinek, emroch, dafyddcrosby, davide125, NaomiReeves, malmond77, joshuamiller01, nishchintraina, bwann and others.
https://github.com/facebook/taste-tester/blob/9603cf3142e0ab5f35382a0b3d5b0f8c45b3ee80/lib/taste_tester/client.rb#L162 This is something I never resolved. It's not actually having any immediate effect, so fixing it is pretty academic. I think the best path forward is to actually depend on the minimum version of minitar directly in this project so we guarantee we get better behaviour.
Summary Removes an invalid keyword from the PowerShell script generated by in . The Bug The method generates a PowerShell heredoc for creating SSH tunnels on Windows targets. However, the script incorrectly includes a keyword at the end of the loop: Why This Is Wrong is bash/shell syntax used to close , , and loops PowerShell uses braces ** to delimit code blocks, not keywords A PowerShell loop is simply - no closing keyword needed The line causes a syntax error when Windows attempts to run the tunnel script Impact This bug prevents SSH tunnel creation on Windows targets. When taste-tester attempts to set up a tunnel to a Windows host, PowerShell will reject the script with a syntax error, causing the tunnel setup to fail. Fix Simply remove the stray line. The loop is already properly closed by its closing brace .