wangle

Summary: X-link: https://github.com/facebook/proxygen/pull/473 X-link: https://github.com/facebook/hhvm/pull/9411 X-link: https://github.com/facebook/fbthrift/pull/587 X-link: https://github.com/facebookincubator/velox/pull/7518 We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd. This function creates C++ bindings using the [cxx] crate. Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390 Differential Revision: D51160627

HHVM OSS[1] mirrors its Meta first-party library dependencies via shipit and consumes them via so that it can be built as a single CMake project. It also vendors a number of third-party library dependencies such as gflags and glog that are also dependencies of these first-party library dependencies. It currently tries to ensure that the glog include directories and link libraries used when compiling and linking folly point to the vendored glog by setting / which are forwarded to and co. by FindGlog.cmake, but this doesn't work because and co. only consider these hint paths after system default paths have been searched, so the system glog (if any) would end up being preferred. So, explicitly opt into CMP0074[2] to allow HHVM to simply set to override the glog search paths. Alternatively, we could also raise the required CMake version to 3.12 (released in 2018) or newer to get the NEW behavior by default. fbthrift has recently started requiring 3.20.2. [1] https://github.com/facebook/hhvm [2] https://cmake.org/cmake/help/latest/policy/CMP0074.html