Last 12 weeks · 28 commits
2 of 6 standards met
following my PR in honojs/middleware, https://github.com/honojs/middleware/pull/2006 I was looking into other hono repos if we should standardize the same package manager across all the repos, it would be weird for the to use bun as a runtime in dev/testing, but looks like bun is used for package manager only. uses bun, uses yarn Should we put more effort into standardizing all the repos or is it fine to keep these repos on bun/yarn as it is right now? cc @yusukebe
Summary This looks like a regression from https://github.com/honojs/node-server/pull/357. That PR added a materialization path that spreads : This is safe when is a plain , but unsafe when it is a native . Native fields such as and are accessor properties, not own enumerable properties, so object spread drops them: As a result, materialization can effectively call , which defaults to status . With (the default), this can make 's lightweight lose its status during materialization. This is not specific to redirects: any non-default status from the native can be ignored and replaced with . A response created from a native : initially reports , but after is read it can become . Regression Range Tested with Node.js and : Reproduction Actual on / : Expected: Suggested Fix Do not spread a native as if it were a plain . Read metadata through accessors: Related: https://github.com/honojs/node-server/issues/304 https://github.com/honojs/node-server/pull/357 https://github.com/honojs/node-server/issues/321
Repository: honojs/node-server. Description: Node.js Server for Hono Stars: 655, Forks: 94. Primary language: TypeScript. Languages: TypeScript (99.1%), JavaScript (0.9%), HTML (0%). License: MIT. Homepage: https://hono.dev Topics: hono, http-server, nodejs, server. Latest release: v2.0.6 (1w ago). Open PRs: 14, open issues: 31. Last activity: 1d ago. Community health: 37%. Top contributors: yusukebe, usualoma, BlankParticle, tangye1234, tavvy, Jayllyz, GavinMeierSonos, mgcrea, nakasyou, tsctx and others.