Last 12 weeks ยท 0 commits
2 of 6 standards met
Repository: kentcdodds/kcd-angular. Description: A repo for all of my useful Angular stuff Stars: 28, Forks: 5. Primary language: JavaScript. Languages: JavaScript (43.4%), HTML (40.4%), CSS (10.8%), Pug (3%), Stylus (2.4%). License: MIT. Homepage: http://kentcdodds.com/kcd-angular Open PRs: 0, open issues: 0. Last activity: 5y ago. Community health: 42%. Top contributors: jdart, rmsint, kasperlewau.
Oops, just added this to your gist, but then noticed your other comment mentioning you don't get notifications for comments on gists. Came across an interesting issue. I'm still debugging, but it appears that child component scopes are never destroyed when I do a recompile using this directive. Say I have the following: After I set in the parent component controller and I see the ng-repeat recompile, if I check the scope tree in batarang, I can see all of the old custom-component scopes still hanging out there, and they continue to stack up each time I recompile. I tried adding in my custom-component, and I added a console.log to the $onDestroy hook, and I can see that $onDestroy fires, but it seems like the scope is being recreated or something because the logs continue to compound after each reload. Any ideas?
Hi, First, thanks for the great directive . I noticed that it's no possible to watch for nested properties in the current directive. For instance, let's suppose in the controlleur: In HTML I would have (inside an ng-repeat="persons"): However, as a nested property, recompilation would not happen if I do: The fix that I did is to add the argument "true" to the watch made by the directive like so: Is it possible to merge it in the current directive? Or better: adding it as an option: What do you think? Thanks.