Last 12 weeks · 0 commits
6 of 6 standards met
Fixes #49 What: Switches test to use a regex that passes for changed error message from to Why: Test suite fails when asked to rerun all tests How: Pass a regex that will match the error message (error message node 16+) and (error message node 15-) into the tests . Checklist: [ ] Documentation [x] Tests [x] Ready to be merged
Everything is still working fine, test suite didn't catch the new URL error message changing between node 15 and 16 version: version: version: Relevant code or config Terminal output What you did: Ran , reran all tests on with both and What happened: test expecets , error message in node 16+ is now just Reproduction repository: This repo Screenshot Problem description: new URL error message changed between node 15 and 16, validateUrl test expects specific error message Suggested solution: Compare against both error messages via a regex: Expect to throw without defining the error message:
Repository: kentcdodds/netlify-shortener. Description: Your own free URL shortener with Netlify Stars: 808, Forks: 85. Primary language: JavaScript. Languages: JavaScript (100%). License: MIT. Homepage: https://www.youtube.com/watch?v=HL6paXyx6hM&list=PLV5CVI1eNcJgCrPH_e6d57KRUTiDZgs0u Latest release: v2.4.0 (5y ago). Open PRs: 0, open issues: 2. Last activity: 1y ago. Community health: 85%. Top contributors: allcontributors[bot], kentcdodds, andrewmcodes, naton, caarlos0, ddbeck, edm00se, jakejarvis, j-f1, jdorfman and others.