5 of 6 standards met
Repository: kentcdodds/react-workshop-app. Description: An abstraction for all my React workshops Stars: 151, Forks: 36. Primary language: TypeScript. Languages: TypeScript (77.8%), HTML (11.3%), JavaScript (10.4%), CSS (0.5%), Shell (0%). License: MIT. Homepage: https://kentcdodds.com/workshops Latest release: v6.0.2 (3y ago). Open PRs: 0, open issues: 2. Last activity: 3y ago. Community health: 71%. Top contributors: kentcdodds, allcontributors[bot], Snaptags, Aprillion, merodiro, kettanaito, dan-overton, jcat4, nfdiop, marcosvega91 and others.
TypeScript
Last 12 weeks · 0 commits
version: 6.0.1 version: v16.18.0 version: 8.19.2 OS: macOS, M1 chip Relevant code or config What you did: Running the react-fundamentals course (exercise ), I didn't add the in the error message . After running the tests I got the error for the test name, but didn't get the message. I ran What happened: No helpful message appeared, on the integrated vscode terminal nor on the mac terminal. !image Reproduction repository: Problem description: Suggested solution:
What: Closes #298 on react-fundamentals Why: The helper for Alfred the alert is used to give hints on why tests failed. It does so by raising a custom error. In order to not bloat the terminal window with stack traces, the code clears the error's property. It turns out that the stack is what's show in the terminal when tests fail. So when tests fail and the stack is set to a blank string, Alfred the alert's helpful tips don't show up in your terminal. :( How: When investigating, it looks like the stack included both the error's message _and_ a stack trace. So instead of clearing the stack, I replaced the stack's content with just the error's message. Now, only the error message shows up when a test fails. Checklist: [ ] Documentation [x] Tests Existing tests still pass. If necessary, I can add a test that asserts the stack equals the message passed in the constructor? [x] Ready to be merged