Last 12 weeks · 0 commits
1 of 6 standards met
Hi, At the moment, the directiveSpec is empty. The problem is, it will be hard to test the application because there is two big directives, and directives aren't the easiest part when dealing with unit testing. So, what could be done ? IMO, The first thing to do is to move the functions from the directives to their own controller (ie : _uxLampCtrl_ and _genieWishCtrl_ ), it will be, by far, easier to test. I started to do it, but it will take some time. I want to be sure that you are even interested, with this solution or another. And what about splitting uxGenie.js into multiple files to improve readability ? ( it could be _directives.js / controllers.js_ or _uxLamp.js / genieWish.js_ ) Cheers.
When a wish is made, if there was a modifier when the user selected the wish create a modifier object in that lists the modifier names with true/false. This way the wish action could behave slightly differently based on the modifier (like open a new tab and navigate rather than just navigate for example).
Repository: kentcdodds/ux-genie. Description: Directive for GenieJS. Stars: 29, Forks: 5. Primary language: HTML. Languages: HTML (100%). Homepage: http://kentcdodds.github.io/genie Open PRs: 0, open issues: 0. Last activity: 5y ago. Community health: 28%. Top contributors: bitdeli-chef.