Last 12 weeks ยท 2 commits
4 of 6 standards met
Fixes sindresorhus/awesome-lint#37 Summary Add a new rule () to validate header images at the top of an Awesome list README. If a header image exists (excluding the Awesome badge), it must be either: an SVG, or a high-DPI raster image (e.g. ), or (best-effort for local images) have pixel dimensions at least 2ร the displayed /. Why Based on the discussion in sindresorhus/awesome#1314. Low-DPI header images look blurry on HiDPI displays. Tests Added fixtures + unit tests under . Notes The rule detects header images either in the first HTML block (``) or inside the first H1 heading. Badge images are ignored. IssueHunt Summary Referenced issues This pull request has been submitted to: #37: Add rule for linting header image if one exists
Hello! I think there might be some small inconsistency between what runs on new PRs, and the CLI linter. I had the table format in the readme attached to a closed PR: running passed: โ Linting but errored in PR linter: README.md:70:2 โ 69:94 Unexpected unaligned cell, expected aligned pipes, add 14 spaces remark-lint:table-pipe-alignment โ 70:2 Unexpected 0 spaces between cell edge and content, expected 1 space, add 1 space remark-lint:table-cell-padding โ 70:30 Unexpected 0 spaces between cell content and edge, expected 1 space, add 1 space remark-lint:table-cell-padding โ 70:31 Unexpected 0 spaces between cell edge and content, expected 1 space, add 1 space remark-lint:table-cell-padding โ 70:94 Unexpected 0 spaces between cell content and edge, expected between 1 (unaligned) and 13 (aligned) spaces, add between 13 and 1 space remark-lint:table-cell-padding โ 70:94 Unexpected unaligned cell, expected aligned pipes, add 14 spaces (or add - to pad alignment row cells) remark-lint:table-pipe-alignment โ 71:91 Unexpected unaligned cell, expected aligned pipes, add 17 spaces remark-lint:table-pipe-alignment โ 72:15 Unexpected unaligned cell, expected aligned pipes, add 15 spaces remark-lint:table-pipe-alignment โ 73:20 Unexpected unaligned cell, expected aligned pipes, add 10 spaces remark-lint:table-pipe-alignment โ 73:94 Unexpected unaligned cell, expected aligned pipes, add 4 spaces remark-lint:table-pipe-alignment I fixed with below formatting. Linter passed on my new PR here: https://github.com/sindresorhus/awesome/pull/3901
Repository: sindresorhus/awesome-lint. Description: Linter for Awesome lists Stars: 735, Forks: 69. Primary language: JavaScript. Languages: JavaScript (100%). License: MIT. Topics: awesome, lint, linter, nodejs. Latest release: v2.2.3 (1mo ago). Open PRs: 1, open issues: 2. Last activity: 1mo ago. Community health: 71%. Top contributors: sindresorhus, chinesedfan, transitive-bullshit, kdeldycke, hyperupcall, itaisteinherz, TiagoDanin, WillForan, panathea, LucaMartino97 and others.
JavaScript
Based on discussion in https://github.com/sindresorhus/awesome/pull/1314. [ ] If a header image exists (aside from awesome-list badge), ensure it is high-DPI or SVG. IssueHunt Summary Backers (Total: $60.00) issuehunt ($60.00) Submitted pull Requests #225 Add header image rule (SVG/HiDPI) Become a backer now! Or submit a pull request to get the deposits! Tips Checkout the Issuehunt explorer to discover more funded issues. Need some help from other developers? Add your repositories on IssueHunt to raise funds.
This pull request improves the integration of awesome-lint with Awesome Lists. Changes include: Ensuring linting works correctly on README files of Awesome Lists. Cloning the repository temporarily if a GitHub URL is provided. Handling errors gracefully when a README file cannot be found. Updating index.js to correctly process all linting rules. These changes address the discussion in Issue #39 about how awesome-lint should relate to Awesome Lists, making it easier to enforce linting standards on new and existing lists.
denotes a `` in Markdown and is rendered as such. The blockquote element represents a section that is quoted from another source. โ W3C HTML spec, https://html.spec.whatwg.org/multipage/grouping-content.html#the-blockquote-element This block was not not quoting a source. Iโm not sure if this was just an oversight.