filenamify

Summary This fixes handling for Windows reserved device names followed by extensions. Windows treats reserved device names like as reserved even when followed by an extension, such as or . Previously, those names were returned unchanged. This change detects reserved device names before the first and inserts the replacement before the extension. Updates: handles extension-bearing Windows reserved device names by applying the replacement to the reserved base name before the extension. updates / expectations and adds regression coverage for , , and . Behavior change: extension-bearing Windows reserved device names now receive the replacement before the extension. Test plan [x] passes. [x] New regression tests cover Windows reserved names with extensions. [ ] CI rollup checked after open. Notes for maintainers Open to a different output shape if you prefer the replacement after the full filename instead of before the extension.

Noticed this change from 6.0.0 → 7.0.0: Throws "Replacement string cannot contain reserved filename characters" The readme specifies that the replacement "Cannot contain: `:"/\|?* ` as an invalid replacement. Thanks for your work.

At the moment, does not filter out unicode bidi characters such as U+202E RIGHT-TO-LEFT-OVERRIDE. There is some concern that these could be used to construct malicious but innocent-looking filenames: becomes: My feeling is that this library should strip these characters, but I'm not 100% certain.