Browser extension - Get notified about new GitHub notifications
by sindresorhusJavaScript
Last 12 weeks · 0 commits
4 of 6 standards met
Summary Restore recovery from offline state when the browser reports it is online again. Keep the connection helper from staying stuck in the offline state after a transient network loss. Add regression coverage for both the connection helper and background recovery path. Validation Fixes #132. IssueHunt Summary Referenced issues This pull request has been submitted to: #132: Notifier stays offline despite regaining connection
Summary This PR improves token documentation, adds fine-grained PAT format support for future compatibility, and fixes a bug preventing API requests in local development. Changes 1. Added fine-grained token format support in options.html Updated the token input pattern to accept format: While fine-grained PATs don't work yet (GitHub doesn't offer a Notifications permission), this future-proofs the extension for when GitHub adds that permission. 2. Fixed missing in manifest.json Added which is required for Manifest V3 extensions to make cross-origin fetch requests. Without this, locally-loaded extensions fail silently. 3. Improved token setup documentation Step-by-step instructions with direct links to GitHub token creation Clear scope table: (required) vs (optional for private repo deep links) Explains why fine-grained PATs don't work yet (GitHub's fine-grained PAT system has no Notifications permission) Security note for users concerned about scope 4. Other documentation improvements Consolidated GitHub Enterprise setup with step-by-step instructions Renamed "Permissions" → "Extension Permissions" to distinguish from GitHub token scopes Fixed "Notifications Permission" description (applies to all desktop notifications, not just public repos) Added "Testing Your Setup" section suggesting users watch a busy repo like microsoft/vscode 5. Security fixes** Ran to address vulnerabilities with non-breaking updates. Test plan [x] Verify classic PAT with scope works (badge count) [x] Verify fine-grained PAT is accepted by input but fails with 403 (expected until GitHub adds Notifications permission) [x] Verify locally-loaded extension makes API requests successfully 🤖 Generated with Claude Code
Summary restore offline recovery in the Manifest V3 background worker by listening for browser connection changes treat API failures as offline-state transitions so the badge recovers cleanly after reconnect add regression coverage for the reconnect path and harden the reconnect assertions and network-error matching Root Cause The current MV3 background worker can render the offline badge, but it does not actively recover when connectivity returns. It also routes fetch-level network failures through a generic error path instead of re-entering offline recovery. Validation Fixes #132.
Summary add online/offline connection listeners so the extension can react immediately when network state changes treat API as an offline condition and render the offline warning badge instead of a generic error keep alarm-based polling active during offline periods so automatic recovery continues without manual icon clicks add tests for connection listeners and network-error classification Why Issue #132 reports that the extension can stay in an offline state until the user manually clicks the extension icon. This patch adds explicit connection-state handling and network-error fallback logic to recover automatically once connectivity returns. Validation (passing) note: fails in this environment due repository lint tooling compatibility ( in eslint-plugin-ava), unrelated to this patch logic IssueHunt Summary Referenced issues This pull request has been submitted to: #132: Notifier stays offline despite regaining connection
Repository: sindresorhus/notifier-for-github. Description: Browser extension - Get notified about new GitHub notifications Stars: 1983, Forks: 144. Primary language: JavaScript. Languages: JavaScript (92.9%), HTML (4.5%), CSS (2.6%). License: MIT. Topics: browser-extension, chrome-extension, firefox-addon, github, github-extension. Latest release: 25.6.25 (1y ago). Open PRs: 6, open issues: 20. Last activity: 1y ago. Community health: 71%. Top contributors: sindresorhus, notlmn, YurySolovyov, fregante, ArnaudLigny, PeterDaveHello, attilaolah, Hydrog3n, gcochard, TheBox193 and others.