Last 12 weeks · 0 commits
4 of 6 standards met
Currently, if the value of an attribute is or , the attribute will be awkwardly stringified: I don't think this is the desirable behavior; I think the desirable behavior would be for such attributes to simply be omitted, as is currently the case with attributes set to . This PR makes this change. The test step is currently failing unrelated to this PR. I have fixed this in #3. Since that PR updates the lint rules, and since the test step is currently broken anyway, I have written this PR to fit with the updated lint rules in #3.
Repository: sindresorhus/stringify-attributes. Description: Turn an object into a string of HTML attributes Stars: 50, Forks: 6. Primary language: JavaScript. Languages: JavaScript (78.5%), TypeScript (21.5%). License: MIT. Latest release: v4.0.0 (2y ago). Open PRs: 0, open issues: 0. Last activity: 2y ago. Community health: 71%. Top contributors: sindresorhus, mattlucock, BendingBender, Richienb.
The test step for this package is currently broken because is erroneously analyzing type definitions from dependencies. I was able to fix this by updating to the newest version, however the Node 12 test step was then failing because of the use of optional chaining and nullish coalescing in updated sub-dependencies. In this PR, I am requiring Node >=14 (Node 12 is now long unsupported anyway) and have updated all dependencies to their newest versions (which involved fixing new lint errors from the updated version of ). All tests now correctly pass in Node 14, 16, and 18.