Last 12 weeks · 0 commits
1 of 6 standards met
After discussing the command injection issue with cristianstaicu I have fixed the code. To summarize the changes: Eliminated the use of the _quote()_ functions. The _args_ array is now handled by the shell-escape lib. Updated the _packages.json_ and added _shell-escape_ as dependency Fixed version number inconsistency between _growl.js_ and _packages.json_, also incremented by _0.0.1_ Updated history file to reflect the relevant changes.
Repository: tj/node-growl. Description: growl unobtrusive notification system for nodejs Stars: 482, Forks: 66. Primary language: JavaScript. Languages: JavaScript (100%). Open PRs: 4, open issues: 8. Last activity: 3y ago. Community health: 28%. Top contributors: tj, deiga, drudge, sukima, perfusorius, fgnass, joshvermaire, niftylettuce, rstacruz, thataustin and others.
v1.10.0 has no arrow functions, v1.10.1 does. This breaks on node < 4, which is a breaking change in a patch version.
Hi, I had added ppc64le(Linux on Power) architecture support on Travis-CI in the PR and looks like its been successfully added. I believe it is ready for the final review and merge. The Travis-CI build logs can be verified from the link below. https://travis-ci.com/github/zazzel/node-growl Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu. Please have a look. Thank you