Last 12 weeks · 0 commits
2 of 6 standards met
Repository: vercel/git-hooks. Description: No nonsense Git hook management Stars: 203, Forks: 8. Primary language: JavaScript. Languages: JavaScript (100%). License: MIT. Latest release: 1.0.0 (4y ago). Open PRs: 0, open issues: 4. Last activity: 4y ago. Community health: 50%. Top contributors: Qix-, rauchg, leerob, rdmurphy.
On Windows it's possible to install the package using an admin console (since folders are read-only for normal users). Otherwise symlink creation will fail due to missing permissions (.cjs files -however- are created, so creating and removing symlinks seems to need more permissions, than file creation):\ (install.js:122:5) Result in with proper credentials (admin) will be e.g.: But uninstall is failing on removing symlinks due to different os path separator (baked into symlink string during creation).\ (codepointer) gives ( before #7) Solution could be: adding different path sepatators as character class to RegExp literal or (better readable): using os path separator from module without RegExp btw. trying to include dynamic path separator into RegExp constructor string is a bit cumbersome due to a lack of proper build-in escaping for RegExp...\ Would be nice to see a patch on this soon. And maybe you can mention this troubleshooting (admin console on Windows) in the README. Also, I had to guess where to put the config JSON, would be nice to mention the package.json in the README as well. kind regards.
@rauchg @leo can you take a look and let me know if this is okay for Vercel? The package needs to be migrated on npm, too, unless you want to approach this some other way. Also, would you be willing to allow me publishing privs again? 😅
Fixes #6. @Qix- You were correct! Adding to all calls and writes of and didn't bother Node v10 (which just runs them as CommonJS as always), and it successfully makes both Node v12 and Node v14 aware. I was just testing it out by uninstalling and reinstalling then triggering the commit hook in the repo I discovered this in, so might benefit from another person poking on it.