4 of 6 standards met
Summary by CodeRabbit Chores Updated Firebase Functions dependency to v7.0.0 Expanded Firebase Functions version compatibility in Nuxt package to include v7.0.0 Updated CI workflow to use Java 21 Tests Refactored Firestore collection tests for improved test isolation ✏️ Tip: You can customize this high-level summary in your review settings.
Reproduction Add auth to your project and it will fail. Steps to reproduce the bug 1. Add auth to your project 2. deploy your app to app hosting. 3. Nuxt build error: Error: [vite]: Rollup failed to resolve import "@firebase/auth" from "/workspace/node_modules/firebase/auth/dist/esm/index.esm.js". 4. Deploy failed. Expected behavior Succesfully deploys app. Actual behavior Deploy fails. Additional information When I run npm run build locally on my computer. It runs without a problem. _No response_
Repository: vuejs/vuefire. Description: 🔥 Firebase bindings for Vue.js Stars: 3914, Forks: 340. Primary language: TypeScript. Languages: TypeScript (82%), Vue (9.8%), JavaScript (6.5%), CSS (0.8%), EJS (0.6%). License: MIT. Homepage: https://vuefire.vuejs.org Topics: database, firebase, firestore, nuxt, pinia, realtime, vue, vuex. Latest release: v3.2.2 (7mo ago). Open PRs: 19, open issues: 27. Last activity: 1mo ago. Community health: 62%. Top contributors: posva, dependabot-preview[bot], greenkeeper[bot], trickstival, davidstackio, danielroe, luc122c, sweethuman, i5dr0id, dependabot[bot] and others.
TypeScript
Last 12 weeks · 1 commit
Reproduction https://github.com/OliverJEvans/firebase-test Steps to reproduce the bug 1. Clone barebones test repo 2. Install deps 3. Link to a Firebase project with at least app hosting setup (Blaze plan required) 4. Build & Deploy 5. Observe 500 error /ssr route throws a 500 /csr renders fine. Visit this project as example: https://my-web-app--testproject-31cc4.europe-west4.hosted.app/ssr The default Firebase app does not exist. Make sure you call initializeApp() before using any of the Firebase services. Disabling auth and redeploying clears this issue. Cloud Build logs report: [warn] [nuxt-vuefire module] You activated both SSR and auth but you are not providing a service account for the admin SDK. See https://vuefire.vuejs.org/nuxt/getting-started.html#configuring-the-admin-sdk. Which I would assume is saying the build can't find the service account. Additional information This codebase was setup from scratch using the official vuefire documentation, using a fresh Firebase project. Perhaps the documentation here is out of date, missing something, or this is a bug? I found it suspicious, however, that there is this discussion from yesterday https://github.com/vuejs/vuefire/discussions/1592. I thought it be appropriate to set up a bare bones reproduction. I appreciate this may not be a Vuefire specific issue, but I would greatly appreciate any help or pointers in the right direction here as I've been looking at this all day. Nuxt: 4.0.3 Vuefire: 3.2.2 nuxt-vuefire: 1.1.0 Firebase: 12.0.0
Reproduction coming soon Steps to reproduce the bug 1. Install 2. Run the following code 3. Observe that resolves early causing any templates that depend on it to flash momentarily before being replaced with data. 4. Observe that the data loads and is ordered correctly. 5. Check the logs for Expected behavior I would expect that passing a query to useCollection would behave the same as passing a raw collection. pending would resolve when fully complete to avoid flashing any template fragments that depend on it there would be no warning data would load correctly Actual behavior pending resolves early, flashing "no companies yet" fragment before replacing with data throws a warning in the console data loads correctly from query, in correct order Additional information I set a breakpoint in the source. Here's the result in Chrome Dev Tools with some of the local context showing. !image
Reproduction https://github.com/dword-design/demo-nuxt-vuefire-getapps-issue Steps to reproduce the bug I get this error when starting a minimal Nuxt project with nuxt-vuefire. !Image Expected behavior The page is shown Actual behavior is shown Additional information My initial idea was that Nuxt has issues with firebase-admin back-importing a cjs file that includes stuff like this:
Summary by CodeRabbit Chores Broadened firebase-functions support to include v7.0.0 across packages for wider compatibility. CI workflow: added manual triggering and a setup step to install Java 21 (Temurin). Tests Adjusted collection-binding tests: skipped an unreliable error test and refactored binding scenarios to validate switching between populated and empty collections. ✏️ Tip: You can customize this high-level summary in your review settings.