5 of 6 standards met
Astro Info If this issue only occurs in one browser, which browser is a problem? N/A Describe the Bug When the live Astro dev server is running, attempting to move any folder containing an image out of a content collection will break it and cause a build failure. On StackBlitz, you should get something like this: !Image What's the expected result? The Astro dev server should not crash and not have a build failure if a piece of content is removed from the collection that references images Link to Minimal Reproducible Example https://stackblitz.com/edit/github-vo52mlan?file=src%2Fcontent%2Fblog%2Ftest-post%2Findex.md Participation [ ] I am willing to submit a pull request for this issue.
fixes #15319, fixes https://github.com/withastro/astro/issues/15437 From @Princesseuh: Updates the default option for the Cloudflare adapter to use the bindings by default, and fix the dev experience on all the other settings. In v6 sharp cannot work in dev anymore because it doesn't run in workerd, so everything became passthrough. Additionally, this PR changes how we do the picomatch excludes to ensure we don't import CJS at runtime in the endpoint. Sucks that picomatch is still in CJS. Docs: https://github.com/withastro/docs/pull/13267 Original comment here Changes Previously, an error occurred when using the Cloudflare adapter in combination with the `astro/assets/endpoint/dev@astrojs/cloudflare/image-endpointcompile-image-service.test.jsimageService` options, I have left it as is for now to facilitate the review process. Docs N/A
Repository: withastro/astro. Description: The web framework for content-driven websites. ⭐️ Star to support our work! Stars: 57155, Forks: 3177. Primary language: TypeScript. Languages: TypeScript (53%), JavaScript (42.5%), Astro (3.9%), CSS (0.1%), Vue (0.1%). Homepage: https://astro.build Topics: astro, blog, browser, components, hybrid, islands, node, server, static, static-site-generator, universal. Latest release: astro@5.18.0 (3d ago). Open PRs: 67, open issues: 188. Last activity: 5h ago. Community health: 100%. Top contributors: matthewp, astrobot-houston, FredKSchott, ematipico, Princesseuh, natemoo-re, bluwy, github-actions[bot], florian-lefebvre, bholmesdev and others.
TypeScript
Last 12 weeks · 539 commits
Summary Fixes #15627 Scripts rendered through with were being hoisted to the top of the slot output instead of rendering at their original position. This regression was introduced by PR #15147, which changed from returning a plain HTML string to returning a object. Root Cause In , objects (including scripts) were collected into a separate array. When the was stringified in , all instructions were rendered before the content string — causing scripts to be hoisted to the top of the slot output regardless of their original position. Fix Uses positional placeholders (`scriptInstructionsSlotStringstringifyChunkrenderedScriptsserver-islands.tspackages/astro/src/runtime/server/render/slot.tsscriptInstructionsSlotStringpackages/astro/src/runtime/server/render/common.tsSlotStringpackages/astro/src/runtime/server/render/server-islands.ts` [x] Existing test passes: "Scripts in Fragment slots are processed when another slot is unused" [x] Existing test passes: "includes script from slotted component in island response" [x] All 35 script + server-island tests pass [x] Build passes
Changes What does this change? Be short and concise. Bullet points can help! Before/after screenshots can help as well. Don't forget a changeset! Run . See https://contribute.docs.astro.build/docs-for-code-changes/changesets/ for more info on writing changesets. This PR brings really small change but valuable - change path for Biome schema to Biome installed schema instance instead of remote source. This change fixup the maintenance overhead to keep the schema up-to-date when installed package can control it. The Biome docs suggest to use the internal ones https://biomejs.dev/reference/configuration/#schema FYI: I need a help defining which changeset I should use for this change. Testing Tested in VsCode IDE, all rules, even after cmd-> 'Biome restart' works. Docs